Re: gEDA-dev: Comment does not match list definition

[Carlos Nieves Ónega <cnieves@xxxxxxxxxx>]

Hi Timur,
Patch applied into git repository. I also added a comment about
considering pin line width when calculating a reference point (related
to your other mail).

Thanks,

Carlos

El dom, 03-02-2008 a las 21:54 +0200, Timur Aydin escribió:
> Timur Aydin <ta@xxxxxxxxxx> writes:
> 
> > Hi,
> >
> > I was examining the default-attrib-positions.scm file today. There is a
> > comment on top of the list that explains each individual item in that
> > list. It seems the comment does not match the actual list
> > definition. Here is a patch that would correct this:
> >
> > --- default-attrib-positions.scm.original       2008-02-03 21:46:26.000000000 +0
> > 200
> > +++ default-attrib-positions.scm        2007-12-30 04:50:19.000000000 +0200
> > @@ -29,15 +29,15 @@
> >     ;      The attribute is going to be placed at a position of the
> >     ;      component, given by the "reference" item.
> >     ;      It has the following items:
> > -   ;        - x_offset, y_offset: the position offset to the reference point.
> > -   ;          The attribute position is offset by these amounts from the
> > -   ;          reference point. They can be positive or negative integers.
> >     ;        - reference: the component's reference point where to place 
> >     ;          the attribute.
> >     ;          It is a string with the format "horizontal vertical", where:
> >     ;            - "horizontal" is one of: "Left",  "Middle", "Right".
> >     ;            - "vertical"   is one of: "Lower", "Middle", "Upper".
> >     ;          Example: "Lower Right".
> > +   ;        - x_offset, y_offset: the position offset to the reference point.
> > +   ;          The attribute position is offset by these amounts from the
> > +   ;          reference point. They can be positive or negative integers.
> >     ;        - alignment: the attribute text's alignment.
> >     ;        - angle: the attribute's angle.
> >     ;
> >
> > -- 
> > Timur Aydin
> >
> 
> Oops, above patch is not correct. Here is how it should be. This is
> applied to the 1.4.0 release of gEDA.
> 
> --- default-attrib-positions.scm.original       2008-02-03 21:52:12.000000000 +0200
> +++ default-attrib-positions.scm        2008-02-03 21:52:31.000000000 +0200
> @@ -29,15 +29,15 @@
>     ;      The attribute is going to be placed at a position of the
>     ;      component, given by the "reference" item.
>     ;      It has the following items:
> +   ;        - x_offset, y_offset: the position offset to the reference point.
> +   ;          The attribute position is offset by these amounts from the
> +   ;          reference point. They can be positive or negative integers.
>     ;        - reference: the component's reference point where to place 
>     ;          the attribute.
>     ;          It is a string with the format "horizontal vertical", where:
>     ;            - "horizontal" is one of: "Left",  "Middle", "Right".
>     ;            - "vertical"   is one of: "Lower", "Middle", "Upper".
>     ;          Example: "Lower Right".
> -   ;        - x_offset, y_offset: the position offset to the reference point.
> -   ;          The attribute position is offset by these amounts from the
> -   ;          reference point. They can be positive or negative integers.
>     ;        - alignment: the attribute text's alignment.
>     ;        - angle: the attribute's angle.
>     ;
> 
> 



_______________________________________________
geda-dev mailing list
geda-dev@xxxxxxxxxxxxxx
http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev