[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [gftp] Patch that corrects problems with Novell ls parsing
- To: firstname.lastname@example.org
- Subject: Re: [gftp] Patch that corrects problems with Novell ls parsing
- From: Brian Masney <email@example.com>
- Date: Mon, 1 Nov 2004 06:12:49 -0500
- Delivered-to: firstname.lastname@example.org
- Delivered-to: email@example.com
- Delivered-to: firstname.lastname@example.org
- Delivery-date: Mon, 01 Nov 2004 06:13:09 -0500
- In-reply-to: <4183DADF.email@example.com>
- References: <4183DADF.firstname.lastname@example.org>
- Reply-to: email@example.com
- Sender: firstname.lastname@example.org
- User-agent: Mutt/18.104.22.168+cvs20040105i
Thanks for this patch, I just merged it into CVS. The tarball
http://www.gftp.org/gftp-test.tar.bz2 has my latest code as well.
On Sat, Oct 30, 2004 at 08:18:07PM +0200, Thomson wrote:
> Hi there!
> My name is Tomek Mrugalski and I'm a long time user of GFTP. I'd like to
> say that it is a great piece of software.
> But it has one bug, which troubled me. In my LAN there's a Novell FTP
> server. It's admin is not so well informed,
> so he is using usernames with spaces. It's a stupid idea, but some
> admins do it anyway. So I had to fix GFTP
> to properly support this.
> In function gftp_ls_parse_novell(...) in lib/protocol.c, there are
> problems with parsing when Novell username contains spaces. Oh well.
> GFTP is unable to parse those entries, so there's a patch needed:
> fle->group = g_strdup (_("unknown"));
> while (*startpos!=0 && !isdigit(*startpos))
> fle->size = gftp_parse_file_size (startpos);
> And here's output of diff protocol.c and prococol2.c
> > while (*startpos!=0 && !isdigit(*startpos))
> > startpos++;
> Well, that's all.
> Greetings from Poland
> Tomasz Mrugalski, | "I think there is a world market for |
> email@example.com | about five computers." |
> | Thomas J. Watson (Chairman, IBM) 1943|