Re: [Libevent-users] patch for libevent-2.1.8 to get past errors about void functions doing "return"

[Azat Khuzhin <a3at.mail@xxxxxxxxx>]

On Mon, Jun 18, 2018 at 05:33:28PM +0100, Dennis Clarke wrote:
> 
> I can only assume that gcc ignores these.

Not only gcc, but any "popular enough" compiler:
- gcc
- clang
- icc
- ellcc

Even MSVC can handle this already (2017, though 2015 fails).

<snip>

> *** ./http-internal.h_backup    Tue Nov  1 15:34:53 2016
> --- ./http-internal.h   Mon Jun 18 15:16:32 2018
> ***************
> *** 182,193 ****
>   /* connects if necessary */
>   int evhttp_connection_connect_(struct evhttp_connection *);
> 
> ! enum evhttp_request_error;
>   /* notifies the current request that it failed; resets connection */
>   void evhttp_connection_fail_(struct evhttp_connection *,
>       enum evhttp_request_error error);
> 
> ! enum message_read_status;

<snip>

Ugh, *please* use *unified diff* (diff -u) if any. Way more convenient
to send output of the `git diff` or you can be even more polite by
sending via `git send-email` but you should have a local patch first in
your git tree of course.

Anyway thanks for the attention, but it is already fixed in [1] (and
maybe some other patches), that said that you can try compile libevent
from the upstream.

  [1]: https://github.com/libevent/libevent/commit/8acfb0cd21cc5f1382fd4d88063d739b76189a5b

Regards,
Azat.

P.S. sending patches inlined into email (i.e. mixed with other
paragraphs without any formatting) is not a good thing to go with.
***********************************************************************
To unsubscribe, send an e-mail to majordomo@xxxxxxxxxxxxx with
unsubscribe libevent-users    in the body.