Re: [Libevent-users] Sorry -- patch review is going slowly (and how you can help)

[Azat Khuzhin <a3at.mail@xxxxxxxxx>]

On Tue, Sep 30, 2014 at 02:10:05AM +0400, Azat Khuzhin wrote:
> On Thu, Sep 18, 2014 at 11:48:19AM -0400, Nick Mathewson wrote:
> > On Thu, Sep 18, 2014 at 11:07 AM, Azat Khuzhin <a3at.mail@xxxxxxxxx> wrote:
> > > On Thu, Sep 18, 2014 at 06:50:24PM +0400, Azat Khuzhin wrote:
> >  [...]
> > >> Hi Nick,
> > >>
> > >> Could you please look through this simple patches:
> > >> https://github.com/libevent/libevent/pulls?q=is%3Aopen+is%3Apr+no%3Aassignee+author%3Aazat+created%3A2014-03-01..2014-08-01+
> > >
> > > Also this is very simple, and correct from my point of view:
> > > https://github.com/libevent/libevent/pull/123
> > > (Otherwise we will comparing only first one byte from evb_two buffer)
> > 
> > 
> > Thanks for the reminder!  I've just had a look over these, merged a
> > few, and commented on the rest.
> 
> Hi Nick,
> 
> Could you please look at this patches:
> - https://github.com/libevent/libevent/pull/170
>   https-client: add -retries argument, for connection retries
>   (This one is used by #171)
> 
> - https://github.com/libevent/libevent/pull/171
>   bufferevent_openssl: reset fd_is_set when setfd with -1 is called
> 
> - https://github.com/libevent/libevent/pull/174
>   Dns fail disable when inactive fix v3
> 
>   We already have discussion for this one, I responded to you here
>   https://github.com/libevent/libevent/pull/131#commitcomment-7838163
>   But I found one more problem there (I was confused because of too many
>   topic branches not merged yet), it triggered by
>   dns/retry_disable_when_inactive, and the last patch fixes the issue.
> 
> - *http retry*
>   I also have patch for http retry code (there are some issues with it),
>   but I want cover it by regression tests before submitting it upstream.

Here is a pull request for this one:
https://github.com/libevent/libevent/pull/175

But there are some problems with regress for this patch.

Cheers,
Azat.
***********************************************************************
To unsubscribe, send an e-mail to majordomo@xxxxxxxxxxxxx with
unsubscribe libevent-users    in the body.