[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #2163 [Vidalia]: Disable menubar icon in OS X

#2163: Disable menubar icon in OS X
---------------------------------+------------------------------------------
 Reporter:  jabes                |          Owner:  chiiph        
     Type:  enhancement          |         Status:  assigned      
 Priority:  normal               |      Milestone:                
Component:  Vidalia              |        Version:  Vidalia 0.2.10
 Keywords:  os x, menubar, icon  |         Parent:                
   Points:                       |   Actualpoints:                
---------------------------------+------------------------------------------

Comment(by jrklein):

 edmanm:

 Thank you. Please bear with me since I'm a newcomer. I really appreciate
 this type of feedback!

 1) The .plist template is already being populated by CMAKE and placed in
 the correct folder (Vidalia.app/Contents/Info.plist).  This was happening
 before I came along.  I just specified a custom file so that I could add
 the LSUIElement setting required by this patch.  Please confirm if
 something should be done differently here?

 2) This makes sense.  After investigating names for #3, I'll likely rename
 "Dock" to "TaskbarOnly" and "Tray" to "TrayOnly" while defining these
 constants.  Open to other name suggestions.

 3) I like your suggestion much better.  I'll go with the following names,
 unless I shouldn't abbreviate the constant name either?

 SETTING_ICON_DISPLAY_PREF    "IconDisplayPreference"

 I'll submit an updated patch in the next day or two.  Thanks again!

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2163#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs