[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #8235 [Tor]: pathbias_count_build_success()

#8235: pathbias_count_build_success()
----------------------------+-----------------------------------------------
    Reporter:  cypherpunks  |       Owner:  mikeperry                  
        Type:  defect       |      Status:  needs_revision             
    Priority:  major        |   Milestone:  Tor: 0.2.4.x-final         
   Component:  Tor          |     Version:  Tor: 0.2.4.10-alpha        
  Resolution:               |    Keywords:  tor-client, MikePerry201304
      Parent:               |      Points:                             
Actualpoints:               |  
----------------------------+-----------------------------------------------

Comment(by mikeperry):

 Replying to [comment:14 andrea]:
 > Begin code review:
 >
 >  * 2e1dd2d9d0ab11160ab6c45e6923551b50717027 looks fine to me
 >  * In c29da58ecb58f6513a4a3051144b285bb3653f3e, you're emitting log
 message if the counts become inconsistent after scaling but were
 consistent before (counts_are_sane && ...); if !counts_are_sane, are we
 certain to have already warned when that condition first occurred, or can
 this cause it to silently not log?  Change this or say you're sure this is
 the case, I think.

 I don't believe the checks in this particular commit will silence any log
 messages. The changes to entrynodes.c in 2e1dd2d9 might silence some, but
 they are meant to cover the cases where previous tor versions had
 overcounting bugs that this one does not.

 Should I perhaps promote 2e1dd2d9 to notice level? It might be nice to
 know if that keeps happening... I can add a version check in there for
 0.2.4.10-alpha I guess (assuming that is easy).

 Otherwise, I think these log messages will at least get us closer to
 solving this bug. Of course, I don't claim that any of these commits solve
 it for sure as of yet. (That's why the changes file is so gimpy and
 doesn't mention any solved bugs or versions).

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8235#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs