[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #11190 [Obfsproxy]: obfsproxy shebang should point to "python2", not "python"

#11190: obfsproxy shebang should point to "python2", not "python"
-------------------------+-------------------------------------------------
     Reporter:  yawning  |      Owner:  asn
         Type:  defect   |     Status:  reopened
     Priority:  normal   |  Milestone:
    Component:           |    Version:
  Obfsproxy              |   Keywords:  python version, obfsproxy, tbb,
   Resolution:           |  flashproxy, MikePerry201404R
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------

Comment (by yawning):

 Replying to [comment:6 dcf]:
 > Replying to [comment:5 yawning]:
 > > I'm not sure how many python scripts we actually ship in TBB 3.6, but
 the correct fix for obfsproxy is in my userrepo as `bug_11190`.  Other PTs
 that contain `#!/usr/bin/python` should also be changed, since it's fairly
 clear that the build process doesn't cause distutils/setuptools to modify
 all of the scripts.

 Well that would explain why the descriptor is just copying the script from
 the source tree.  asn is there any reason why this is the case?

 To be honest I think doing both (changing the shebang to be more
 explicity) *and* fixing setup.py is the right thing to do here, if only
 because I hate having bin/obfsproxy being perpetually stuck in my git
 status as changed (Yes, I could just stick it in `.git/info/exclude` since
 it's unlikely to change much, but I shouldn't have to).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/11190#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs