[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #15747 [Tor Browser]: Improve start-tor-browser argument handling on Linux

#15747: Improve start-tor-browser argument handling on Linux
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  tbb-team
  mikeperry              |     Status:  needs_review
         Type:  defect   |  Milestone:
     Priority:  normal   |    Version:
    Component:  Tor      |   Keywords:  tbb-4.5-alpha,
  Browser                |  TorBrowserTeam201504, MikePerry201504
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by weasel):

 I have copied the script, and it seems to work just fine.  Thanks a lot.

 Looking at the script, I wonder why in the elif [ "$show_output" -eq 1 ];
 then case you redirect stderr to stdout.

 Also, there's the usual shell ickyness that some variable usess might want
 quoting, such as $logfile.

 Cheers,

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15747#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs