[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
[tor-bugs] #15852 [Tor Browser]: Remove/synchronize Torbutton SOCKS pref logic
#15852: Remove/synchronize Torbutton SOCKS pref logic
-------------------------------------------------+-------------------------
Reporter: mikeperry | Owner: tbb-
Type: defect | team
Priority: normal | Status: new
Component: Tor Browser | Milestone:
Keywords: tbb-4.5-regression, | Version:
TorBrowserTeam201505 | Actual Points:
Parent ID: | Points:
-------------------------------------------------+-------------------------
In 4.5 (#14630), we removed the Torbutton settings window because I
assumed that users could use the Firefox proxy setting instead.
Unfortunately, Torbutton still has code to check if its SOCKS settings
match the browser proxy settings, and to disable itself if these are out
of sync.
We should remove this old code so that it is easier for people to point
TBB at a different Tor instance. The code is a toggle-era relic, and we
have a control port check anyway.
We should also ensure that if the Tor check fails, Torbutton's features
aren't actually disabled, and that the difference is only a cosmetic
warning. Right now, I fear that features are actually disabled, due to
other toggle-era checks.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15852>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs