[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #18362 [Core Tor/Tor]: Tor could use a generic 'handle' implementation.

#18362: Tor could use a generic 'handle' implementation.
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  enhancement                          |         Status:
 Priority:  High                                 |  merge_ready
Component:  Core Tor/Tor                         |      Milestone:  Tor:
 Severity:  Normal                               |  0.2.9.x-final
 Keywords:  modularity, TorCoreTeam201604, tor-  |        Version:
  modularity                                     |     Resolution:
Parent ID:                                       |  Actual Points:
 Reviewer:  dgoulet                              |         Points:  small
                                                 |        Sponsor:
                                                 |  SponsorS-can
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 We can basically use this as a "delete flag" for an object in a single
 thread environment instead of updating every reference to an object once
 it gets freed. I don't have any use case from the top of my head that
 could use that but I'm sure they exist and will come. And heck, if this
 becomes thread-safe one day, extra bonus :).

 Before you merge, nitpick: please change this at the end: `#endif /*
 TOR_HANDLE_H */`

 lgtm;

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18362#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs