Re: [tor-bugs] #18793 [Metrics/CollecTor]: add checkstyle task

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#18793: add checkstyle task
-------------------------------+------------------------------
 Reporter:  iwakeh             |          Owner:  iwakeh
     Type:  enhancement        |         Status:  needs_review
 Priority:  Medium             |      Milestone:
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:  ctip               |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+------------------------------
Changes (by iwakeh):

 * status:  new => needs_review


Comment:

 Please find attached two patches:

 The first just fixes ERNIE to CollecTor naming in comments and logging
 statements and adds entries to gitignore.

 The second adds the checkstyle task (`ant checks`) to build.xml
 I used the latest checkstyle-all-6.17 jar from
 [https://sourceforge.net/projects/checkstyle/files/checkstyle/
 checkstyle.sf.net]; it contains all dependencies for checkstyle.

 The configuration is the taken from checkstyle's google-checks.
 I put it in `resources/metrics-checks.xml`.

 The results of running `ant checks` are written to
 `generated/checkstyle_report.txt`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18793#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs