[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #21710 [Applications/Tor Browser]: Upgrade Go to 1.8.1



#21710: Upgrade Go to 1.8.1
----------------------------------------------+----------------------------
 Reporter:  dcf                               |          Owner:  tbb-team
     Type:  task                              |         Status:
                                              |  needs_review
 Priority:  Medium                            |      Milestone:
Component:  Applications/Tor Browser          |        Version:
 Severity:  Normal                            |     Resolution:
 Keywords:  tbb-gitian TorBrowserTeam201704R  |  Actual Points:
Parent ID:                                    |         Points:
 Reviewer:                                    |        Sponsor:
----------------------------------------------+----------------------------
Changes (by dcf):

 * keywords:  tbb-gitian => tbb-gitian TorBrowserTeam201704R
 * status:  new => needs_review


Comment:

 Hi, two patches for review:
  * attachment:0001-Bump-SANDBOX_TAG-to-
 35fb3e0cebd73c9a93bee68e1a12a596.patch: "Fix compilation with Go 1.8."
  * attachment:0002-Bug-21710-Upgrade-Go-to-1.8.1.patch: Upgrades GO_VER
 and GO_HASH and removes a workaround.

 There's no tag of sandboxed-tor-browser that has the Go 1.8 fix yet (the
 first patch). I don't know if you want to wait for a new tag before
 merging this.

 I tested this with `make alpha` on top of
 [https://gitweb.torproject.org/user/gk/tor-browser-
 bundle.git/commit/?h=bug_21753_v3&id=d0465e4ce9e9fa13a46faae8c7401b5fb78582f8
 bug_21753_v3] from #21753. I only tested running it on linux-amd64
 (bootstrapping with obfs4).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21710#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs