[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #21647 [Core Tor/Tor]: Prop140: directory caches cache multiple past diffs or consensuses

#21647: Prop140: directory caches cache multiple past diffs or consensuses
---------------------------------------+-----------------------------------
 Reporter:  nickm                      |          Owner:  nickm
     Type:  enhancement                |         Status:  needs_revision
 Priority:  Medium                     |      Milestone:  Tor:
                                       |  0.3.1.x-final
Component:  Core Tor/Tor               |        Version:
 Severity:  Normal                     |     Resolution:
 Keywords:  prop140 TorCoreTeam201704  |  Actual Points:  6
Parent ID:  #13339                     |         Points:  2
 Reviewer:  ahf                        |        Sponsor:  Sponsor4
---------------------------------------+-----------------------------------
Changes (by ahf):

 * status:  needs_review => needs_revision


Comment:

 Been walking over this code now, both patch-by-patch and the overall
 change. I think it looks good. I've added some minor things that might
 need some fixing. The API looks sensible and the code seems pretty easy to
 understand when diving into it.

 There's still a lot of `XXX`'s in the worker code, which should probably
 receive some love.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21647#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs