[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #23846 [Core Tor/Tor]: Use libtool for building shared library
#23846: Use libtool for building shared library
-------------------------------------------------+-------------------------
Reporter: hellais | Owner: sbs
Type: enhancement | Status:
| needs_review
Priority: Medium | Milestone: Tor:
| 0.3.4.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-mobile, s8-api, | Actual Points:
034-triage-20180328 034-included-20180402 034 |
-roadmap-subtask |
Parent ID: #25510 | Points:
Reviewer: nickm | Sponsor:
| Sponsor8
-------------------------------------------------+-------------------------
Comment (by nickm):
So, I've looked over the codebase and made a couple of changes in a branch
called "libtool_hack", including a workaround for the Rust warning issue.
(It's only a plausible legitimate workaround if Rust builds with -fPIC
though -- does it?)
Here are the open issues I want to check, if we can:
* Does this work on windows? (Only the Makefile.am build is supported)
* Does "make distcheck" still work? (It does without Rust. But with
Rust, "make distcheck" appears to be broken in master already without this
patch. Fixing.)
* How horrible is the above Rust hack?
One other issue here is that since none of the library are installed, no
real shared libraries are actually built. (You can verify this yourself
by noticing that no .so files are created anywhere.) I'm _thinking_ that
this is intentional, but I'm
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23846#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs