[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25523 [Metrics/Library]: Add support for webstats tarballs



#25523: Add support for webstats tarballs
-----------------------------+-----------------------------------
 Reporter:  karsten          |          Owner:  iwakeh
     Type:  defect           |         Status:  needs_revision
 Priority:  Medium           |      Milestone:  metrics-lib 2.3.0
Component:  Metrics/Library  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+-----------------------------------
Changes (by karsten):

 * status:  needs_review => needs_revision


Comment:

 This patch does enable metrics-lib to parse webstats tarballs. So far so
 good!

 However, `Descriptor#getDescriptorFile` now returns a "virtual" `File`
 reference for the tarball entry, rather than the `File` reference of the
 tarball. For example, here are the results of that method for a webstats
 log and consensus:

 {{{
 www-staging.torproject.org_stellatum.torproject.org_access.log_20150211.xz
 in/consensuses-2017-02.tar.xz
 }}}

 The specification of that method says: "Return the file, tarball or plain
 file, that contained this descriptor, or null if this descriptor was not
 read from a file."

 Would you like to provide a fix for that? And can you include a change log
 entry for the change? Thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25523#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs