[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #15015 [Core Tor/Tor]: tor --verify-config should not bind to ports



#15015: tor --verify-config should not bind to ports
-------------------------------------------------+-------------------------
 Reporter:  cypherpunks                          |          Owner:  rl1987
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-relay, intro, startup,           |  Actual Points:
  configuration, torrc, bootstrap, refactor,     |
  technical-debt                                 |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_review => needs_revision
 * points:  small =>
 * milestone:  Tor: unspecified => Tor: 0.3.4.x-final


Comment:

 Thanks for this patch.

 The code looks good, but I think we can improve the man page:
 * please put parse-config immediately after verify-config
 * please explicitly document the different use cases for verify and parse:
   * verify may fail if the tor service is already running
   * parse should be used if the tor service is running

 If you'd like, you can also set up Travis CI on your branch, or open a
 pull request on https://github.com/torproject/tor
 https://trac.torproject.org/projects/tor/ticket/23883#comment:3
 It's the first thing the next reviewer will do.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15015#comment:24>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs