[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #1859 [Tor Client]: Using 'mytorexitnode.exit' request when mytorexitnode is both exit and client
#1859: Using 'mytorexitnode.exit' request when mytorexitnode is both exit and
client
------------------------+---------------------------------------------------
Reporter: mwenge | Owner:
Type: defect | Status: needs_review
Priority: normal | Milestone:
Component: Tor Client | Version: Tor: 0.2.2.12-alpha
Keywords: | Parent:
------------------------+---------------------------------------------------
Comment(by nickm):
add_nickname_list_to_smartlist is used in routerlist_add_family().
routerset_get_all_routers() is used in getting entry nodes into the list
of known entries in entry_guards_prepend_from_config.
So these two add routers from the user's configuration, whereas the others
potentially add routers based on external information.
I think the right thing to do is:
* Special-case those two functions to check for the own-nickname case
* Change router_get_by_nickname to not check for the own-nickname case
* Add a router_get_by_extend_info(), and use that everywhere we currently
use router_get_by_nickname(extend_info->nickname)
tractor just noted that router_get_by_nickname checks for
UNNAMED_ROUTER_NICKNAME early, so the Unnamed bug doesn't manifest quite
so easily. Nevertheless, there are still ways to exploit this, so we
should fix it.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1859#comment:25>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs