[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #3724 [Torctl]: Support CONF_CHANGED events

#3724: Support CONF_CHANGED events
-------------------------+--------------------------------------------------
 Reporter:  krkhan       |          Owner:  krkhan            
     Type:  enhancement  |         Status:  needs_review      
 Priority:  normal       |      Milestone:  Tor: 0.2.3.x-final
Component:  Torctl       |        Version:                    
 Keywords:               |         Parent:  #1692             
   Points:               |   Actualpoints:                    
-------------------------+--------------------------------------------------

Comment(by robinson):

 I reviewed this and I have many questions.

 Where is the specification for CONF_CHANGED events?  I don't see it in
 control-spec.txt.

 Would this be the first multi-line event handled by TorCtl?  Otherwise,
 why the additions to _handle1()?  Why should multi-line events be handled
 this way (e.g. set(codes)), rather than each line separately?

 I recommend this be implemented under Daemon's rewrite of the event
 handler in ticket #3679.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3724#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs