[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #9599 [EFF-HTTPS Everywhere]: HTTPS Everywhere builds should be deterministic

#9599: HTTPS Everywhere builds should be deterministic
--------------------------------------+-----------------
     Reporter:  micahlee              |      Owner:  pde
         Type:  task                  |     Status:  new
     Priority:  normal                |  Milestone:
    Component:  EFF-HTTPS Everywhere  |    Version:
   Resolution:                        |   Keywords:
Actual Points:                        |  Parent ID:
       Points:                        |
--------------------------------------+-----------------

Comment (by micahlee):

 We figured out why it's not deterministic. Running makexpi.sh runs utils
 /merge-rulesets.py, which regenerates
 src/chrome/content/rules/default.rulesets. And it turns out that zip files
 contain the last modified date of each file. So each time you run
 makexpi.sh, you're changing the modified date of default.rulesets, and
 therefore the xpi file ends up with a different checksum.

 It looks like this code is here specifically to touch default.rulesets to
 change it's modified timestamp: https://gitweb.torproject.org/https-
 everywhere.git/blob/HEAD:/utils/merge-rulesets.py#l85

 But it's not working. When you run makexpi.sh, default.rulesets ends up
 with the current time anyway.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/9599#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs