[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #12205 [Tor]: Document magic numbers at entry_is_time_to_retry()

#12205: Document magic numbers at entry_is_time_to_retry()
-------------------------+--------------------------------
     Reporter:  asn      |      Owner:  rl1987
         Type:  defect   |     Status:  needs_review
     Priority:  trivial  |  Milestone:  Tor: 0.2.6.x-final
    Component:  Tor      |    Version:
   Resolution:           |   Keywords:  tor-guard
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+--------------------------------
Changes (by rl1987):

 * status:  needs_revision => needs_review


Comment:

 I refactored the aforementioned function using table approach:

 https://github.com/rl1987/tor/commits/bug12205_take2

 This seems to be begging for unit test though. Or is this function tested
 implicitly by test(s) of other function(s)?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12205#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs