[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #22839 [Core Tor/Tor]: Build tor with Rust code enabled on Windows
#22839: Build tor with Rust code enabled on Windows
--------------------------------------+------------------------------------
Reporter: isis | Owner: snoek
Type: task | Status: needs_review
Priority: Medium | Milestone: Tor: 0.3.2.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: rust, windows, tor-build | Actual Points:
Parent ID: | Points: 1
Reviewer: | Sponsor: SponsorZ
--------------------------------------+------------------------------------
Changes (by nickm):
* status: assigned => needs_review
* milestone: Tor: unspecified => Tor: 0.3.2.x-final
Comment:
Wow. That is a tremendous amount of work, and thank you for doing it!
I don't know any reason we shouldn't be able to update mingw/msys, but we
should make sure that we do it in concert with our regular package
builders. If possible, we shouldn't break people who try to use the old
mingw without Rust, without giving them some time to upgrade. (But only
if possible!)
The tor-memwipe.c fix looks fine to me. I think it's a potential backport
as far as 0.2.8. (The bug seems to have been introduced in 0.2.7.2-alpha
with commit 27bc0da14d1c9c91bfe31d88c862cd00972ab187, but 0.2.7.x isn't
supported any more.)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22839#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs