[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #23215 [Metrics/CollecTor]: set annotation from descriptor during sync-runs

#23215: set annotation from descriptor during sync-runs
-------------------------------+---------------------------------
 Reporter:  iwakeh             |          Owner:  iwakeh
     Type:  defect             |         Status:  needs_review
 Priority:  Medium             |      Milestone:  CollecTor 1.3.0
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:                     |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+---------------------------------

Comment (by karsten):

 Looks good!

 Nitpick: let's avoid abbreviations in variable names and write
 "annotations" instead of "annos" and "result" instead of "res". It'll cost
 5 seconds more to write this code but save at least 5 seconds each time
 somebody reads this code.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23215#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs