[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #27342 [Core Tor/sbws]: sbws poor error handling



#27342: sbws poor error handling
---------------------------+--------------------------------
 Reporter:  gabe           |          Owner:  pastly
     Type:  defect         |         Status:  needs_revision
 Priority:  Medium         |      Milestone:
Component:  Core Tor/sbws  |        Version:
 Severity:  Normal         |     Resolution:
 Keywords:                 |  Actual Points:
Parent ID:                 |         Points:
 Reviewer:                 |        Sponsor:
---------------------------+--------------------------------
Changes (by pastly):

 * status:  needs_review => needs_revision


Comment:

 (notes to self)

 Need tests so this doesn't happen again. https://github.com/pastly/simple-
 bw-scanner/pull/244#issuecomment-416423613

 When starting to implement tests, noticed that there's a little rot that
 needs taking care of. [https://github.com/pastly/simple-bw-
 scanner/blob/0ffe0d42fd429042b583ee081fc609dbbb36a714/tests/integration/conftest.py#L55
 here we set --directory] as an argument, but it isn't an argument anymore.
 I found this because I need to get the config into a file and pass it as
 an argument so I can launch sbws in a subprocess.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27342#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs