[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #31300 [Applications/Tor Launcher]: Modify Tor Launcher so it is compatible with ESR68
#31300: Modify Tor Launcher so it is compatible with ESR68
-------------------------------------------------+-------------------------
Reporter: mcs | Owner: brade
Type: defect | Status:
| needs_review
Priority: Medium | Milestone:
Component: Applications/Tor Launcher | Version:
Severity: Normal | Resolution:
Keywords: ff68-esr, tbb-9.0-must-nightly, | Actual Points:
TorBrowserTeam201908R |
Parent ID: | Points:
Reviewer: | Sponsor:
-------------------------------------------------+-------------------------
Comment (by mcs):
Replying to [comment:5 acat]:
> Mostly looks good and works fine for me.
>
> One small question I have regarding the added css:
>
> {{{
> +groupbox {
> + margin-left: 16px;
> + padding: 8px;
> + background-color: rgba(215, 215, 219, 0.5);
> }}}
>
> Where does the `background-color` come from? I checked in my machine
with current tor-launcher, and I don't see any background-color difference
with the background, but after this patch I do (see screenshots).
In ESR60, OS styling was used for groupbox. Kathy and I did not realize
that it is so different on Linux vs. macOS vs. Windows... we just did
something that is similar to the older macOS look. It looks like on Linux
there was no styling to "set off" the groupbox contents, while macOS had a
darkened background, and Windows 10 has a gray line around the contents. I
like the shading/darkened background but we can revisit this later once
more people can look at it, e.g., in a nightly build.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31300#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs