[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #31088 [Core Tor/Tor]: Check IPv4 and IPv6 private addresses in descriptors, first hops, and extends
#31088: Check IPv4 and IPv6 private addresses in descriptors, first hops, and
extends
-------------------------------------------------+-------------------------
Reporter: teor | Owner: neel
Type: defect | Status:
| needs_revision
Priority: Medium | Milestone: Tor:
| unspecified
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: ipv6, tor-relay, tor-client, tor- | Actual Points:
dirauth |
Parent ID: #24403 | Points:
Reviewer: nickm, teor | Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):
* status: needs_review => needs_revision
* reviewer: nickm => nickm, teor
Comment:
Replying to [comment:9 teor]:
> Replying to [comment:2 neel]:
> > Also here:
> > > And when clients connect:
> > >
https://github.com/torproject/tor/blob/f7e8b3b68c8e2cecfc7ff4072e9f00d316aaba4f/src/core/or/circuitbuild.c#L552
> >
> > I didn't see any mention of separate IPv4 or IPv6 addresses here or in
`extend_info_t`.
>
> That's because you're working on a child ticket of #24403, which will
introduce separate IPv4 and IPv6 addresses in extend_info_t. (Or proposal
306 will introduce them if we do it first.)
>
> Please open a separate ticket for the parts of this ticket that you
can't do yet, because they depend on future planned changes.
You've added some code that isn't needed yet. Please reject all IPv6
extends in this patch, and open a separate child ticket of #24403 for
allowing IPv6 extends.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31088#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs