[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #31176 [Core Tor/Tor]: Teach practracker about .may_include files



#31176: Teach practracker about .may_include files
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  practracker, tech-debt,              |  Actual Points:  1
  refactoring, easy, 041-deferred-20190530,      |
  network-team-roadmap-august                    |
Parent ID:  #29746                               |         Points:  1.5
 Reviewer:  teor, asn                            |        Sponsor:
                                                 |  Sponsor31-can
-------------------------------------------------+-------------------------
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Design looks reasonable.

 We should update the file-level comment of practracker.py to mention that
 we are now checking for include dependecies too. Same goes for the header
 of exceptions.txt .

 And maybe it's time to make a small README file to specify all the metrics
 that practracker is currently looking for, before they become too many?

 Also, I wonder if we should be requiring unittests for practracker
 features.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31176#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs