[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #30544 [Metrics/Library]: Using try-with-resources or close resource



#30544: Using try-with-resources or close resource
-----------------------------+--------------------------------
 Reporter:  fava             |          Owner:  metrics-team
     Type:  defect           |         Status:  needs_revision
 Priority:  Medium           |      Milestone:
Component:  Metrics/Library  |        Version:
 Severity:  Major            |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+--------------------------------

Comment (by fava):

 Hi karsten

 Replying to [comment:5 karsten]:
 >  - There are some minor whitespace issues. Please run `ant checks`
 before submitting a patch.
 I created a new version of path starting from updated master, fix `ant
 checks` whitespace and comment rewrited with your advice
 [[attachment:30544-resource-leak-v2.zip​]]

 I also update my remote branch https://github.com/f-a-v-a/metrics-
 lib/tree/30544-try-with-resources .

 >  - Those TODO comments look reasonable, but let's maybe try to just fix
 them now, each of them in a separate commit. Otherwise we'll just collect
 more things to do in the sources.
 I prefer to create a new trac tasks for TODO comment after this patch will
 be merged into master branch. This help me to focus on one activity at
 time and split different activities

 >  - Our commit messages typically start with a roughly 50 chars long
 summary line, followed by two newlines, followed by text wrapped to 70
 chars. Can you try to rephrase your commit messages accordingly?
 Done
 >  - Can you rebase your edited commits to master?
 Done
 >  - When you post a patch or branch, be sure to change status to
 needs_review. To be clear, this is not the main reason for us not
 reviewing sooner, but it could be a possible reason for future delays.
 As I wrote on 21 May 2019 "Re: [metrics-team] Sonarqube on metrics-lib" :
 {{{
 So I created the first issue on trac system [1] (Using
 try-with-resources or close resource) but I cannot change status to in
 progress or assign to me.
 }}}

 Please let me know your code review,
 Best Regards

 fava

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30544#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs