[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #7666 [Stem]: Support TAKEOWNERSHIP command
#7666: Support TAKEOWNERSHIP command
-------------------------+--------------------------------------------------
Reporter: lunar | Owner: atagar
Type: enhancement | Status: needs_review
Priority: normal | Milestone:
Component: Stem | Version:
Keywords: | Parent:
Points: | Actualpoints:
-------------------------+--------------------------------------------------
Comment(by atagar):
> In stem/control.py, s/thrugh/through/.
fixed
> ... having it run for a longer time (perhaps five minutes) shouldn't
hurt anything.
Ideally I'd like to get rid of all of the sleep() calls in the tests in
favor of something like a scheduled executor since they suffer from a
similar drawback. However, I'm not familiar with a counterpart for that
class in python.
Raised the sleep to a minute. I'd like to keep it reasonably low so the
tests can't leave orphaned processes if the kill() request fails.
> Your Controller class's support for the TAKEOWNERSHIP command assumes
that Stem will always be run in the same process-ID namespace
Good point. Changed the TAKEOWNERSHIP call to only take place if the
control socket is for localhost.
https://gitweb.torproject.org/stem.git/commitdiff/120907822f06fd476f2c47b7135e816cd730b1c7
Anything else, or is this good to be resolved?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7666#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs