[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #7666 [Stem]: Support TAKEOWNERSHIP command



#7666: Support TAKEOWNERSHIP command
-------------------------+--------------------------------------------------
 Reporter:  lunar        |          Owner:  atagar      
     Type:  enhancement  |         Status:  needs_review
 Priority:  normal       |      Milestone:              
Component:  Stem         |        Version:              
 Keywords:               |         Parent:              
   Points:               |   Actualpoints:              
-------------------------+--------------------------------------------------

Comment(by lunar):

 > Out of curiosity, why are you using launch_tor() rather than
 launch_tor_with_config() for this? It should both make the code nicer, and
 avoid having a huge process name.

 In the TAKEOWNERSHIP pattern '__OwningControllerProcess' needs to be given
 on the command-line. Otherwise reset_conf() would not work. Now that
 launch_tor_with_config() will do TAKEOWNERSHIP properly, it can be used.

 There's another thing though. I think that a Python dictionary is not the
 proper structure for Tor configuration options. As several options can
 appear multiple times (Log or Bridge), I think a list of 2-uples is better
 suited...

 > Neat, I wasn't familiar with pycurl. Do you know if it has been added to
 the builtin library? It could be handy for future tests.

 It's in the python-pycurl package in Debian. I have not researched other
 plateforms. Its interface is not that pythonic, but at least it works.

 Many thanks for the other advices. :)

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7666#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs