[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #13928 [Tor]: Tor Authorities reachability testing is predictable and sequential
#13928: Tor Authorities reachability testing is predictable and sequential
------------------------+--------------------------------
Reporter: teor | Owner: teor
Type: defect | Status: needs_review
Priority: normal | Milestone: Tor: 0.2.6.x-final
Component: Tor | Version: Tor: 0.2.6.1-alpha
Resolution: | Keywords: tor-auth
Actual Points: | Parent ID: #14034
Points: |
------------------------+--------------------------------
Changes (by teor):
* status: needs_revision => needs_review
Comment:
Nick, I've created an experimental branch for the changes in #13929 &
#13928, controlled using the macros:
* `DIRSERV_SCALE_REACHABILITY` - #13929
* `DIRSERV_PERMUTE_REACHABILITY` - #13928
Using these macros makes it easy for me to tell the difference between
refactored code and new code. They will need to be permantently activated,
or turned into torrc options, in the final version.
Also, in order to do unit testing, I have created functions that can be
set to a fixed value for testing. These functions can be mocked by passing
them any value other than `DSV_STD` (`DSV_STD` produces the standard, non-
testing behaviour).
This probably needs to be converted to the tinytest way, once I get my
head around it.
I'm not expecting feedback any time soon - merging and alpha-testing
#13718 is a higher priority, and I also need to polish the fixes in #13192
before going another round with authorities.
Commits: Refactoring, Unit Testing, #13929, #13928 (in that order)
Branch: experimental-auth-reachability
Repository: ââââââââhttps://github.com/teor2345/tor.git
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13928#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs