[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #17779 [Tor]: Memory leak in routerkeys.c
#17779: Memory leak in routerkeys.c
------------------------------------+------------------------------------
Reporter: cypherpunks | Owner:
Type: defect | Status: new
Priority: Medium | Milestone: Tor: 0.2.7.x-final
Component: Tor | Version: Tor: 0.2.7.2-alpha
Severity: Normal | Resolution:
Keywords: TorCoreTeam201512 easy | Actual Points:
Parent ID: | Points:
Sponsor: |
------------------------------------+------------------------------------
Comment (by cypherpunks):
Replying to [comment:2 teor]:
> It would be great if we could fix this in December.
>
> But we might want to think about how we do it - it appears that
get_master_rsa_crosscert is for generating RSA/ED cross-certificates.
The function itself doesn't generate anything, it just assigns pointers.
Also if you grep for its name you only get its declaration and its
definition. Nothing calls it. (Makes me wonder why the compiler isn't
complaining about it.)
> Perhaps we can free the rsa_ed_crosscert variable in one of the
functions that cleans up Tor memory?
> Do we expect that the rsa_ed_crosscert variable will ever change value?
If so, it needs to be freed before it's overwritten, too.
This was my initial solution until it found out nothing uses the variable.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17779#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs