[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #17739 [Tor]: Refactor clock skew warning code to avoid duplication

#17739: Refactor clock skew warning code to avoid duplication
---------------------------+------------------------------------
 Reporter:  teor           |          Owner:
     Type:  enhancement    |         Status:  needs_review
 Priority:  Medium         |      Milestone:  Tor: 0.2.9.x-final
Component:  Tor            |        Version:  Tor: 0.2.7
 Severity:  Normal         |     Resolution:
 Keywords:  easy refactor  |  Actual Points:
Parent ID:  #9675          |         Points:
  Sponsor:                 |
---------------------------+------------------------------------

Comment (by dgoulet):

 Replying to [comment:3 arlolra]:
 > Something like that?

 I like it!

 Would be really nice if you could add comment on top of this new function
 explaining the parameters like why do we change severity if it's trusted
 or not?. Also, maybe you should `const` a bit of params to make it
 explicit that we shouldn't change any of them (`conn`, `received` and
 `source`).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17739#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs