[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #18873 [Core Tor/Tor]: Refactor circuit_predict_and_launch_new()
#18873: Refactor circuit_predict_and_launch_new()
------------------------------------------+--------------------------------
Reporter: asn | Owner: chelseakomlo
Type: defect | Status: assigned
Priority: Low | Milestone: Tor:
| 0.3.0.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: refactoring, review-group-13 | Actual Points:
Parent ID: | Points:
Reviewer: dgoulet, teor | Sponsor:
------------------------------------------+--------------------------------
Comment (by chelseakomlo):
> One final thing I was thinking about is naming. In several places in the
code, I use the term "hs servers" , but that probably isn't right. I've
heard the term "hidden service routers" or just "hidden services." If you
have consistent naming for these that you prefer, let me know and I can
fix those up as well. For example, `needs_hs_server_circuits` and
`SUFFICIENT_UPTIME_INTERNAL_HS_SERVERS`
>
Ok, I chatted with asn, and hs_servers is fine, especially because it
makes the distinction from clients in this case.
I made fixes for Nick's feedback, final code at
`git@xxxxxxxxxx:chelseakomlo/tor_patches.git`, branch `circuituse`.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18873#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs