[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #20502 [Core Tor/Tor]: Setting UseBridges=1 UseEntryGuards=0 means you bypass your bridges
#20502: Setting UseBridges=1 UseEntryGuards=0 means you bypass your bridges
-------------------------------------+------------------------------------
Reporter: arma | Owner:
Type: defect | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.3.0.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: config, review-group-14 | Actual Points:
Parent ID: | Points: 1
Reviewer: chelseakomlo | Sponsor:
-------------------------------------+------------------------------------
Comment (by chelseakomlo):
Replying to [comment:13 nickm]:
> When I apply this, I get a new unit test failure:
> {{{
> options/validate__reachable_addresses: [forking]
> FAIL src/test/test_options.c:1876: assert(ret OP_EQ 0): -1 vs 0
> [validate__reachable_addresses FAILED]
> }}}
>
Yes, I get the same failure.
> Also, why is it necessary to add "UseEntryGuards 1" to the unit tests
there? "UseEntryGuards 1" is already supposed to be the default. Are our
tests getting the defaults wrong?
It looks like UseEntryGuards is not set in TEST_OPTIONS_DEFAULT_VALUES. Is
the expectation that test defaults map to production defaults, unless
overridden in specific tests?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20502#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs