[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #22990 [Metrics/Library]: Add a heartbeat log message indicating progress and estimated time left
#22990: Add a heartbeat log message indicating progress and estimated time left
-----------------------------+--------------------------------
Reporter: karsten | Owner: iwakeh
Type: enhancement | Status: needs_revision
Priority: Medium | Milestone:
Component: Metrics/Library | Version:
Severity: Normal | Resolution:
Keywords: metrics-2017 | Actual Points:
Parent ID: | Points:
Reviewer: iwakeh | Sponsor:
-----------------------------+--------------------------------
Comment (by karsten):
Replying to [comment:12 iwakeh]:
> Replying to [comment:10 karsten]:
> > ...
> > > More importantly, `readTarballs` needs to catch the IOE to avoid
halting the process just b/c of one tarball being faulty.
> >
> > Ugh, very good point. That's an oversight.
>
> This is an excellent example where having decent tests would serve as
documentation and ensuring that the wanted behavior, i.e., keep
processing, is kept when making changes.
Indeed.
And it's also an excellent example how code review works! :)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22990#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs