Re: [tor-bugs] #30558 [Applications/Tor Browser]: Namecoin support for onion sites in Tor Browser

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#30558: Namecoin support for onion sites in Tor Browser
--------------------------------------+--------------------------------
 Reporter:  arthuredelstein           |          Owner:  JeremyRand
     Type:  defect                    |         Status:  needs_revision
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam201912      |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:  gk                        |        Sponsor:
--------------------------------------+--------------------------------

Comment (by JeremyRand):

 >  Yes, I can see that point. Let me explain you as well where we are
 coming from: this ticket is not about "getting NameCoin into Tor Browser"
 in the sense that it decides whether to ship this feature in actual
 releases or not. It's about testing optional NameCoin support on one
 platform in nightly builds for those that are interested.
 >
 > However, including the Namecoin patches into tor-browser-build has costs
 far beyond just affecting a particular platform on the nightly series as
 it increases the general complexity of the master branch considerably.
 This is okay, but we should try to minimize that complexity, hence my
 request.
 >
 > That said, in case this experiment is successful and we indeed think
 about shipping Namecoin support to users then we'll maintain it in our
 repo ourselves like we do for all the other projects, too. Thus, it's not
 that you are stuck with maintaining two things.

 Sounds good to me, I'll make the requested changes.

 > Non-reproducible in what way?

 I don't remember off the top of my head, but I do remember that upstream
 Electrum's official binaries are built via `sdist` and they are not
 reproducible.  Might be related to datetime values getting embedded.  If
 omitting `sdist` and solely using rbm's tarball generation doesn't pan
 out, I'll investigate this more closely.

 > No, that's not needed. Right now we don't have much Python code in our
 projects, thus I think it's not worthwhile to spend time on that at the
 moment. Maybe that would change if we decided to integrate Namecoin beyond
 the nightly testing we plan to do, but that would still be at some point
 in the future which we don't need to worry about right now.

 Okay.

 > I meant if issues 1)-4) affect later commits please fix those commits up
 as well while you are addressing this round of feedback.

 Ah, ok.  Glad I asked.  :)

 I'll aim to have a new branch for you within a couple days.  (Might be
 quicker than that if things go smoothly.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30558#comment:31>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs