[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32798 [Core Tor/Tor]: Compile every header by itself as part of "make check"



#32798: Compile every header by itself as part of "make check"
--------------------------+------------------------------------
 Reporter:  teor          |          Owner:  (none)
     Type:  task          |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:  #32764        |         Points:  2
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by nickm):

 This is a really good idea!  It might be biting off more than I can chew
 this week, however: when I did a quick-and-dirty test here, I found that
 only 57% of our headers currently build on their own, even after the fixes
 in #32764.  That leaves 177 headers to fix, which is a lot to tackle.

 I think that maybe we could do this without special handling for
 HAVE_MODULE_*; since our CI runs with the full matrix of disable-module-
 foo, then we should learn about any headers where we've broken with a
 module turned off.

 I'm going to hack on my quick-and-dirty test script a bit more, then
 upload it so we can iterate and improve it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32798#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs