[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #32818 [Core Tor/Tor]: Standardise EXPOSE and INTERNAL macros to PRIVATE

#32818: Standardise EXPOSE and INTERNAL macros to PRIVATE
--------------------------+------------------------------------
 Reporter:  teor          |          Owner:  teor
     Type:  task          |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:  0.2
Parent ID:  #32798        |         Points:  0.5
 Reviewer:  nickm         |        Sponsor:
--------------------------+------------------------------------
Changes (by teor):

 * status:  assigned => needs_review
 * reviewer:   => nickm
 * actualpoints:   => 0.2


Comment:

 I also standardised PRIVATE_ to PRIVATE.

 The only unusual change is renaming CHANNEL_PRIVATE_ and
 TOR_CHANNEL_INTERNAL_ to CHANNEL_FILE_PRIVATE and CHANNEL_OBJECT_PRIVATE.
 Otherwise, they would have been ambiguous.

 See my PR:
 * master: https://github.com/torproject/tor/pull/1623

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32818#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs