[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #3594 [Tor]: Add support for SOCKS parameters in Bridge and {Client, Server}TransportPlugin lines

#3594: Add support for SOCKS parameters in Bridge and
{Client,Server}TransportPlugin lines
---------------------------+------------------------------------------------
 Reporter:  asn            |          Owner:                    
     Type:  defect         |         Status:  needs_review      
 Priority:  normal         |      Milestone:  Tor: 0.2.4.x-final
Component:  Tor            |        Version:                    
 Keywords:  pt tor-bridge  |         Parent:  #7211             
   Points:                 |   Actualpoints:                    
---------------------------+------------------------------------------------
Changes (by asn):

  * status:  needs_revision => needs_review


Comment:

 Thanks for the review!

 I think I addressed all your comments in branch
 `bug3594_rebased_and_fixed` in
 `https://git.torproject.org/user/asn/tor.git`.

 I'd also like to replace `tor_addr_port_lookup()` in `parse_bridge_line()`
 with something like `tor_addr_port_parse()` but I'm not sure what's the
 reason the `_lookup()` function was originally there.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3594#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs