[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #8368 [Tor]: Add tor.service (for systemd) to upstream package

#8368: Add tor.service (for systemd) to upstream package
-----------------------------+--------------------------------
     Reporter:  jamielinux   |      Owner:
         Type:  enhancement  |     Status:  needs_review
     Priority:  normal       |  Milestone:  Tor: 0.2.5.x-final
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:  tor-relay systemd
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+--------------------------------

Comment (by misc):

 I would remove --quiet and set it in the configuration if needed. For
 --runasdaemon, this is needed for Type=simple, so changing that setting
 would break the service file ( ie, if it fork when we tell to not fork ),
 but it can be dropped if we switch to Type=notify as proposed in another
 bug report.

 I am not sure ExecStop is needed, since by default, a SIGTERM is sent. If
 that's not sufficient, I would say using KillSignal would be better that
 explicitly using kill, 1 less fork :)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8368#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs