[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #14059 [Tor Browser]: Revision of existing double key cookie logic to meet requirements

#14059: Revision of existing double key cookie logic to meet requirements
-------------------------+-------------------------------------------------
     Reporter:  michael  |      Owner:  michael
         Type:  defect   |     Status:  needs_information
     Priority:  normal   |  Milestone:
    Component:  Tor      |    Version:
  Browser                |   Keywords:  TorBrowserTeam201502R,
   Resolution:           |  GeorgKoppen201502R
Actual Points:           |  Parent ID:  #3246
       Points:           |
-------------------------+-------------------------------------------------

Comment (by gk):

 Here comes the first part of the review:

 1) nsCookie.*: looks good to me.
 2) CookieServiceParent.cpp: "Method is called nowhere" is not correct
 (anymore). CookieService* are for e10s (see:
 https://bugzilla.mozilla.org/show_bug.cgi?id=537156) which is already on
 Mozilla's dev channels activated. Eventually we need to port double keying
 to it, too. But at least the comment should make that clear.
 3) nsICookie2.idl: Why is `aOrigin` of type `ACString` and not
 `AUTF8String` (like `host`, `rawHost` etc.)?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14059#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs