[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #17949 [Tor]: Make loopback address search more accurate
#17949: Make loopback address search more accurate
------------------------------------+------------------------------------
Reporter: teor | Owner: rl1987
Type: enhancement | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.2.8.x-final
Component: Tor | Version:
Severity: Normal | Resolution:
Keywords: easy TorCoreTeam201602 | Actual Points:
Parent ID: #17991 | Points: medium
Sponsor: |
------------------------------------+------------------------------------
Comment (by bugzilla):
Replying to [comment:16 teor]:
> And `if (loopback)` is equivalent to `if (loopback != 0)`.
{{{loopback}}} in function calls was meant.
> We don't use `bool` anywhere else in the codebase. This isn't the place
to start.
Developers of C language couldn't decide when to start too (until C99
became a standard).
See Mozilla's pain about it: https://blog.mozilla.org/mwu/2011/07/28/the-
twelve-booleans-of-mozilla/
For this ticket proposing the advice of Brian Smith (:briansmith,
:bsmith):
>Please use an enum here. In the calling code, it would be unclear whether
true means "strong" or "weak". By using an enum, you avoid that confusion.
(No, bitfield is for the other purposes.)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17949#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs