[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #21439 [Core Tor/Tor]: Add a configure option to disable safety features that make fuzzing harder



#21439: Add a configure option to disable safety features that make fuzzing harder
-----------------------------+------------------------------------
 Reporter:  nickm            |          Owner:  nickm
     Type:  defect           |         Status:  needs_revision
 Priority:  Medium           |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  review-group-16  |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------------
Changes (by ahf):

 * status:  needs_review => needs_revision


Comment:

 Review comments:

 - In configure.ac: would it make sense to only allow memory-sentinels if
 either oss-fuzz or libfuzzer is enabled?
 - Minor nitpick: maybe remove the uncommented `#define DEBUG_SENTINEL` in
 `buffers.c`?

 Other than that the code looks good to me.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21439#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs