[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #22926 [Core Tor/Tor]: The Tor compression code can call functions that are NULL
#22926: The Tor compression code can call functions that are NULL
--------------------------+------------------------------------
Reporter: teor | Owner: ahf
Type: defect | Status: needs_review
Priority: Medium | Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor | Version: Tor: 0.3.1.1-alpha
Severity: Normal | Resolution:
Keywords: | Actual Points:
Parent ID: | Points: 1
Reviewer: | Sponsor:
--------------------------+------------------------------------
Comment (by teor):
I think Nick is right, checking for NULL functions could rapidly get out
of control.
(I don't think we should check for mandatory libraries. But then I asked
myself: why bother to check at all?)
I suggest we check that the zstd and lzma library functions are non-NULL
at configure time. And fail if they are NULL.
That way, builders get instant feedback if their linker flags or install
are broken.
People who design custom build processes will have to make sure they work
themselves.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22926#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs