Re: [tor-bugs] #25317 [Metrics/CollecTor]: Enable webstats to process large (> 2G) logfiles

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#25317: Enable webstats to process large (> 2G) logfiles
-------------------------------+--------------------------------
 Reporter:  iwakeh             |          Owner:  iwakeh
     Type:  defect             |         Status:  needs_revision
 Priority:  High               |      Milestone:
Component:  Metrics/CollecTor  |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:                     |  Actual Points:
Parent ID:                     |         Points:
 Reviewer:                     |        Sponsor:
-------------------------------+--------------------------------
Changes (by karsten):

 * status:  needs_review => needs_revision


Comment:

 Two issues:
  - Should `return new LocalDate[]{LocalDate.MAX, LocalDate.MIN};` have
 `MAX` and `MIN` exchanged? If not, can you document why this is correct?
  - In the block after `if (count >= LISTLIMIT) {`, the local variable
 `count` is not reset. This means that this code will be run after each
 line! Should be sufficient to set `count = 0;` in that block.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25317#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs