[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #24659 [Core Tor/Tor]: Wrap our sha2 interface in Rust which implements the appropriate traits

#24659: Wrap our sha2 interface in Rust which implements the appropriate traits
-------------------------------+------------------------------------
 Reporter:  isis               |          Owner:  (none)
     Type:  enhancement        |         Status:  needs_review
 Priority:  Medium             |      Milestone:  Tor: 0.3.4.x-final
Component:  Core Tor/Tor       |        Version:
 Severity:  Normal             |     Resolution:
 Keywords:  rust, tor-crypto,  |  Actual Points:
Parent ID:                     |         Points:  1
 Reviewer:                     |        Sponsor:  Sponsor3-can
-------------------------------+------------------------------------

Comment (by Hello71):

 as I said on IRC:

 1. -L takes a directory, not a file. see `rustc --help`
 2. `src/rust/external/.cargo/config` is not read. you can verify with
 strace or inotify (or your platform equivalent). must use
 `src/rust/.cargo/config` (which already exists)
 3. rust does not depend on the libraries in the makefile. if you want it
 to work this way, you'd need to add that, otherwise building tor fails. I
 think it would be better to use it only for tests, i.e. use
 `RUSTFLAGS="-L... -l..."` in `src/test/test_rust.sh`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24659#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs