[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #25268 [Core Tor/Tor]: cmux: Remove round robin code and make EWMA mandatory

#25268: cmux: Remove round robin code and make EWMA mandatory
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:  dgoulet
     Type:  enhancement                          |         Status:
                                                 |  merge_ready
 Priority:  Low                                  |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-cmux, tor-sched, tor-relay,      |  Actual Points:
  tor-circuit, review-group-33                   |
Parent ID:  #25328                               |         Points:
 Reviewer:  isis                                 |        Sponsor:
                                                 |  SponsorM-can
-------------------------------------------------+-------------------------
Changes (by isis):

 * status:  needs_review => merge_ready
 * sponsor:   => SponsorM-can


Comment:

 Looks good! I also ran `make check && make test-stem && make test-
 network`, and ran it through Travis where [https://travis-
 ci.org/isislovecruft/tor/builds/347530454 it passed].

 Stem was mad about some stuff, frequently erroring on `[] != ['']`, but
 I'm pretty sure that's a Stem problem? Or my Stem is too old or something
 (v1.4.1). Chutney seemed fine though.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25268#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs