[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #32921 [Core Tor/Tor]: Code and script changes to run clang-format without breaking checkSpaces or coccinelle
#32921: Code and script changes to run clang-format without breaking checkSpaces or
coccinelle
----------------------------+------------------------------------
Reporter: nickm | Owner: nickm
Type: enhancement | Status: needs_review
Priority: Medium | Milestone: Tor: 0.4.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: style, 043-can | Actual Points: 1.5
Parent ID: #29226 | Points:
Reviewer: catalyst | Sponsor:
----------------------------+------------------------------------
Comment (by catalyst):
Proposed changes based on mailing list responses and meetings:
* change to `IndentCaseLabels: false` due to lack of objections
* catalyst will investigate whether Emacs can be easily convinced to
produce the results of `AlignEscapedNewlines: Left` (maybe we can also
decide to leave existing ones alone with `AlignEscapedNewlines:
DontAlign`? but maybe instead that puts space-backslash at the end of the
each line's visible text. I haven't checked.)
* retain `KeepEmptyLinesAtTheStartOfBlocks: false` (no other opinions
about changing it, and my preference isn't very strong)
* change to `SpaceAfterLogicalNot: false` (it removes the need for at
least one other change on the PR that compensates for the introduced
space, and brings us closer to KNF)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32921#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs