[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #3457 [Tor Client]: Expose more circuit state-change events to controllers



#3457: Expose more circuit state-change events to controllers
---------------------------+------------------------------------------------
 Reporter:  rransom        |          Owner:  rransom           
     Type:  enhancement    |         Status:  needs_review      
 Priority:  normal         |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client     |        Version:                    
 Keywords:  small-feature  |         Parent:                    
   Points:                 |   Actualpoints:                    
---------------------------+------------------------------------------------

Comment(by nickm):

 Replying to [comment:10 rransom]:
 > Torperf uses that format.  I agree that it sucks, but I didn't know of
 any formatting functions already in Tor that would emit all the
 information in that time struct.

 How about ISOTime with the space replaced by a slash?  eg,
 2011-01-11/00:02:15.324128

 > >   * void* arg2 is making me uncomfortable.  If that's only a timeval
 for now, let's make it a timeval. If it really has to be lots of other
 things, let's make typechecking wrapper functions as needed.
 > >
 > > rransom, do you have any suggestions for a better name for CIRC2?
 >
 > `CIRC_MINOR`? `CIRC_MINOR_EVENT`?

 CIRC_MINOR seems fine to me.

 I'll do these changes tonight or tomorrow unless  this is something you'd
 rather do.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/3457#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs