[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #4533 [Tor Client]: compat.h: tor_socket_t defined as intptr_t instead native SOCKET (Windows)

#4533: compat.h: tor_socket_t defined as intptr_t instead native SOCKET (Windows)
---------------------------+------------------------------------------------
    Reporter:  troll_un    |       Owner:                    
        Type:  defect      |      Status:  needs_review      
    Priority:  major       |   Milestone:  Tor: 0.2.3.x-final
   Component:  Tor Client  |     Version:                    
  Resolution:              |    Keywords:  Windows easy      
      Parent:              |      Points:                    
Actualpoints:              |  
---------------------------+------------------------------------------------
Changes (by nickm):

  * status:  new => needs_review


Comment:

 At this point the benefit isn't high enough to do the intptr -> socket
 transition in 0.2.3.x, and I'm not sure it will be.  (If win128 makes
 SOCKET a 128-bit type, it'll probably make intptr_t 128-bit too, and vice
 versa.  But just in case, checking the type size at compile time might be
 reasonable.)

 Still, there are some more places we should be using the macros we have.
 See branch "bug4533_part1" in my public repo, which also adds a runtime
 test

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4533#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs